Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cannot disable play / pause on spacebar press #879

Open
1 task done
donalffons opened this issue Feb 26, 2024 · 1 comment
Open
1 task done

Bug: Cannot disable play / pause on spacebar press #879

donalffons opened this issue Feb 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@donalffons
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-player-react

Which browsers are you using?

Chrome

Which operating systems are you using?

Other (add details below)

Description

I would like to playback video "programmatically", i.e. without Mux Player's controls or keyboard listeners.

Reduced test case

No response

Steps to reproduce

I'm using the following code:

  <MuxPlayer
    playbackId={pageData.header.video.asset.playbackId}
    preload="auto"
    autoPlay
    loop
    muted
    playsInline
    className="h-screen w-full object-cover"
    style={{
      // @ts-ignore
      "--controls": "none",
    }}
    nohotkeys
  />

Current Behavior

Playback works and the controls are hidden. But, when I focus the video by clicking on it, I can play / pause by hitting spacebar.

Expected Behavior

My expectation is that the nohotkey prop would disable that. I did check the docs and issues and couldn't find a way to disable play / pause on spacebar.

Errors

No response

What version of the package are you using?

No response

@donalffons donalffons added bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Feb 26, 2024
@cjpillsbury
Copy link
Contributor

Hey @donalffons haven't been able to dig too deeply into this, but this does appear to be a bug. Thanks for reporting! I'll keep you posted when we're able to get this into our priority queue.

@cjpillsbury cjpillsbury removed the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants