Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Extend Hotkeys or Allow Custom Ones #868

Open
1 task done
PJUllrich opened this issue Feb 12, 2024 · 2 comments
Open
1 task done

Feature Request: Extend Hotkeys or Allow Custom Ones #868

PJUllrich opened this issue Feb 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@PJUllrich
Copy link

PJUllrich commented Feb 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-player

Description

It would be great to have additional hotkeys for adjusting the playback speed (e.g. s) and enabling and disabling the picture-in-picture mode (e.g. p). If you don't want to add these hotkeys by default, it would be great if I could add them using e.g. JavaScript event handlers myself.

Expected Behavior

I can circle through the playback speed options using the s key and enable/disable picture-in-picture mode using the p key.

@PJUllrich PJUllrich added the enhancement New feature or request label Feb 12, 2024
@cjpillsbury
Copy link
Contributor

Oh boy this one's a bit trickier to add. Also not a bad request, but not sure if we'll be adding this one as soon. This would also be a Media Chrome feature. If we could provide you with a workaround at the app layer, would that be of interest to you for the interim?

@PJUllrich
Copy link
Author

Ah I see. Yes, if I could add a keybinding myself and change the playback speed programmatically, that'd be great and feasible for me. My only question would be: How can I know which playback speeds does the mux-player support? So, if I want to change the speed through an API call, I would need to know the possible options. I could also imagine an API that simply make the video one step faster or slower. That'd work as well. The changes would need to be reflected in the UI though. So, after I make the call, the playback speed UI in the player should update too. And possibly the settings should be persisted in LocalStorage as discussed in the other ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants