Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: React player causes horizontal overflow after video starts #865

Open
1 task done
spenweb opened this issue Feb 5, 2024 · 1 comment
Open
1 task done

Bug: React player causes horizontal overflow after video starts #865

spenweb opened this issue Feb 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@spenweb
Copy link

spenweb commented Feb 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-video-react

Which browsers are you using?

Chrome, Safari, Safari on iOS

Which operating systems are you using?

iOS

Description

The video player causes unnecessary horizontal overflow after playing the video. As a workaround, I add overflow: hidden to the player and the issue goes away.

mux-player-react-x-overflow.mp4

The test case comes straight from the documentation: https://docs.mux.com/guides/mux-player-web#example-react-implementation
Here is a copy of the Code Sandbox just in case the original from the documentation is removed: https://codesandbox.io/p/sandbox/awesome-fast-89pwqp

Reduced test case

https://codesandbox.io/p/sandbox/pedantic-firefly-tgwf2x?file=%2FApp.js

Steps to reproduce

  1. Press play
  2. Scroll to the right
  3. Notice horizontal scroll
  4. Question my own understanding of CSS 🙃

Current Behavior

The video player causes unnecessary horizontal overflow after playing the video.

Expected Behavior

There should be no horizontal overflow.

Errors

No response

What version of the package are you using?

v2.3.2

@spenweb spenweb added bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Feb 5, 2024
@luwes luwes removed the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Feb 7, 2024
@luwes
Copy link
Contributor

luwes commented Feb 7, 2024

thank you for reporting this! I can reproduce it, seems something in the media-control-bar is causing the overflow but I don't see what right away.

edit: seems the selectmenu elements are causing it

we will look into this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants