encoding image file name

[lghio]

I'm using this pattern to insert the relative link to my images

and unfortunately the spaces aren't encoded.

Could you add an option to encode the variables "imageFileName" ?

Thank you for this great extension

[lirantal]

@lghio there's already logic in the code to handle encoding for spaces. To make that work, you need to enable the config item encodePath and set its value to urlEncodeSpace.

[lghio]

I understand the settings but it only works on the imagePath, it does not work on the imageName
and I want to use a relative name, so I can't use the imagePath

[lirantal]

Oh I think you're right, it's encoding applied to the imageFilePath:

vscode-paste-image/src/extension.ts

Lines 383 to 387 in fb79532

	if (this.encodePathConfig == "urlEncode") {
	imageFilePath = encodeURI(imageFilePath)
	} else if (this.encodePathConfig == "urlEncodeSpace") {
	imageFilePath = imageFilePath.replace(/ /g, "%20");
	}

It looks like it would be a relatively easy fix to add an encoding for the filename specifically. That's what you're asking for, right?

[lghio]

Yes that's it ;-)
When do you think that could be implemented?

[lirantal]

I've no idea, I don't have any access to this repo, just a developer using this extension :-)

[lirantal]

@lghio I submitted a pull request here to suggest the code changes that might fix this issue.

Still, need the maintainer(s) around to review, merge, and publish a new version.