Crash at opening if "Show clef" in Staff/Part Properties is unchecked

[cadiz2]

Issue type

Crash or freeze

Bug description

All is in the title

Steps to reproduce

1. Create new score for Acoustic Guitar (Tablature) or Banjo (Tablature) no matter
2. Right-click the staff -> Staff/Part Properties -> Untick "Show Clef" -> OK
3. Save/Quit
4. Reload
   Result: CRASH

Screenshots/Screen recordings

MuseScore Version

Version 4.3

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.3.0-241231433, revision: github-musescore-musescore-5f36e74

Additional context

• Same crash with the template Guitar + Tablature (but if both clefs, Treble clef et TAB clef, are hidden in Staff/Part Properties) Works at opening if the TAB clef is hidden and Treble clef showed.

• I know there have been changes with the TAB clefs for 4.3.
  Could the fix of this issue be involved? Changing Clef overwrites "TAB" clef on linked staff #20180

• Related post on forum: https://musescore.org/en/node/363885

[zacjansheski]

Confirmed regression of 4.2

[zacjansheski]

Diagnostic files:

TabCrash.zip

[zacjansheski]

Reproduction score (if helpful)
TabCrash.mscz.zip

[RomanPudashkin]

Most likely caused by d3a6f81

[cbjeukendrup]

I'm about to open a PR

[cadiz2]

Thanks!
Could you please check that this patch also covers this use case (probably?) that has just appeared on the forum, here: https://musescore.org/en/node/364024

On the attached file (BWV 527 Bc), the TAB clef is hidden (the trigger of the issue) while the lower staff shows a bass clef. So it doesn't crash when you open the file.

On the other hand, as the OP points out, it does crash when creating Parts, so

1. Open this file
2. Parts -> "Open all"
   Result: crasch

[zacjansheski]

#22802 does resolve that issue as well!

[cadiz2]

Great. Thanks!