Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Loop Playback' Feature doesn't work correctly with repeats #16875

Closed
XiaoMigros opened this issue Mar 17, 2023 · 11 comments · Fixed by #22718
Closed

'Loop Playback' Feature doesn't work correctly with repeats #16875

XiaoMigros opened this issue Mar 17, 2023 · 11 comments · Fixed by #22718
Assignees
@mathesoncalum
Labels
P1 Priority: High playback General playback issue regression_ms3 Regression from MS3 (3.6.2)

Comments

@XiaoMigros
Copy link
Contributor

XiaoMigros commented Mar 17, 2023 •
edited

Issue type

General playback bug

Bug description

The 'Loop Playback' option misinterprets repeats, and doesn't seem to take them into account when assigning playback points to loop to/from. Explained visually in a project file linked below.

Steps to reproduce

  1. Create a new Score
  2. Add repeats of any kind (regular repeats, voltas, jumps)
  3. Select a range to play looped during or after a repeat jump (a point after which the cursor has 'jumped' at least once)
  4. Enable looped playback and play the range
  5. The loop is offset by the amount of music repeated

Screenshots/Screen recordings

image

MuseScore Version

4.0.2

Regression

Yes, this used to work in Musescore 3.x and now is broken

Operating system

Windows 10

Additional context

Loop Playback Bug Demonstration.zip

(this is actually a .mscz file that it wouldn't let me upload without renaming)
@muse-bot muse-bot added playback General playback issue regression Regression on a prior release labels Mar 17, 2023
@BanjoJake
Copy link

Here's another example, I think, of the same bug. Select All, Loop Playback, Jumps to start after first measure of B section
MS4 Playback bug.zip
Observed in MS 4.02 on Windows 11

@pcollinson
Copy link

Here's another example:
Coleman's March-m4.mscz.zip
Plays normally once through, click on loop button, start again and when it gets to the B section it jumps back to the start of A at the end of bar 11, (bar 2 in the B).

Also try selecting the 'A' section, adding a loop, this has repeatable odd jump back behaviour.

This is on iMac Monterey, the file was imported from MU3 mscz and automatically converted, if that is useful information.

I do note that the synchronisation problem with tempo changes present in the initial release of MU4 seems to be fixed on MU 4.0.2.

This problem is a show stopper for how I want to use MU, and I am currently sticking with MU3 until it's fixed. MU4 does sound much better though.

@DmitryArefiev DmitryArefiev added regression_ms3 Regression from MS3 (3.6.2) and removed regression Regression on a prior release labels Apr 26, 2023
@DmitryArefiev DmitryArefiev added this to To do in 4.x SHORTLIST via automation Apr 26, 2023
@DmitryArefiev DmitryArefiev added the P1 Priority: High label Apr 26, 2023
@DmitryArefiev DmitryArefiev removed their assignment Apr 26, 2023
@DmitryArefiev
Copy link
Contributor

I can repro all cases. Thanks for logging!

@musescore musescore deleted a comment from pcollinson May 30, 2023
@musescore musescore deleted a comment from Jojo-Schmitz May 30, 2023
@musescore musescore deleted a comment from pcollinson May 30, 2023
@NinjaNas NinjaNas mentioned this issue Jun 24, 2023
Closed
@rgreen5
Copy link

rgreen5 commented Jun 25, 2023

OS: Linux Mint 20.1, Arch.: x86_64, MuseScore version (64-bit): 4.0.2-230651545, revision: github-musescore-musescore-dbe7c6d

I am getting exactly the same bug with this score.
loop_playback_issue.zip
If you select a loop in the second system it plays back the corresponding measures in the first system instead. The problem disappears when you remove the repeat barline at the end of the first system.

@zacjansheski zacjansheski mentioned this issue Jun 30, 2023
Closed
@zacjansheski zacjansheski mentioned this issue Dec 12, 2023
Closed
@XiaoMigros XiaoMigros mentioned this issue Dec 21, 2023
Closed
@zacjansheski zacjansheski mentioned this issue Jan 11, 2024
Merged
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jan 20, 2024 •
edited

Came up again in https://musescore.org/de/node/359440, along with a sample score

@vHeemstra
Copy link

vHeemstra commented Mar 22, 2024 •
edited

I found similar behaviour in my score: after selecting a range, clicking "Loop Playback" and clicking Play, the playback starts X measures too early.
Where X is the number of measures that are in repeating sections before the beginning measure of the selected loop. Note: The number of times these sections/measures should repeat does not influence this count; it counts as 1 per measure.

Extra info
If you unselect the "Play repeats" option from the playback options, playback starts at the correct measure.

OS: Windows 10 Version 2009 or later
Arch.: x86_64
MuseScore version (64-bit): 4.2.1-240230937, revision: github-musescore-musescore-d757433

@scorster
Copy link

scorster commented Mar 26, 2024 •
edited

I also encountered the issue today (as reported by vHeemstra) in MS 4.2.1.

As he mentioned, the workaround is turning off Play Repeats in the Toolbar settings (the gear icon.)

@cbjeukendrup cbjeukendrup mentioned this issue Apr 15, 2024
Closed
@mathesoncalum mathesoncalum mentioned this issue May 8, 2024
Merged
@BanjoJake
Copy link

Bug still present in MuseScore Studio 4.3

RomanPudashkin added a commit that referenced this issue May 14, 2024
@RomanPudashkin
Merge pull request #22718 from mathesoncalum/16875-loop_playback_repeats
9689f04 
Fix #16875: Broken looped playback when score has repeats
4.x SHORTLIST automation moved this from To do to Done May 14, 2024
@RomanPudashkin RomanPudashkin removed this from Done in 4.x SHORTLIST May 14, 2024
@RomanPudashkin RomanPudashkin mentioned this issue May 16, 2024
Closed
@MikeWilkey
Copy link

I just downloaded OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.3.0-241231433, revision: github-musescore-musescore-5f36e74
This is still an issue. Attempting to loop a score that contains repeats still causes weird jumps. There was a suggestion of setting the score to not play repeats but that defeats the purpose of using MuseScore as a practice partner to play along with since then it is just driving through first and second endings, which is not helpful. If more specific information is need or an example file, let me know.

@gabeluci
Copy link

@MikeWilkey They just fixed this a few days ago, but you won't see it till version 4.4

@MikeWilkey
Copy link

MikeWilkey commented May 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathesoncalum mathesoncalum

Labels
P1 Priority: High playback General playback issue regression_ms3 Regression from MS3 (3.6.2)
Projects
MuseScore Studio 4.3.1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #16875: Broken looped playback when score has repeats mathesoncalum/MuseScore