Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove refcount on TCP sockets for the timers #481

Open
matttbe opened this issue Mar 28, 2024 · 0 comments
Open

remove refcount on TCP sockets for the timers #481

matttbe opened this issue Mar 28, 2024 · 0 comments

Comments

@matttbe
Copy link
Member

matttbe commented Mar 28, 2024

See Eric's commit: 151c9c7
https://lore.kernel.org/r/20240322135732.1535772-1-edumazet@google.com

We can then remove:

/* kernel sockets do not by default acquire net ref, but TCP timer
 * needs it.
 * Update ns_tracker to current stack trace and refcounted tracker.
 */
__netns_tracker_free(net, &sf->sk->ns_tracker, false);
sf->sk->sk_net_refcnt = 1;
get_net_track(net, &sf->sk->ns_tracker, GFP_KERNEL);
sock_inuse_add(net, 1);

We should check if the bug fixed by the code is no longer reproducible without this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant