Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize established options generation #441

Open
pabeni opened this issue Sep 22, 2023 · 0 comments
Open

optimize established options generation #441

pabeni opened this issue Sep 22, 2023 · 0 comments

Comments

@pabeni
Copy link

pabeni commented Sep 22, 2023

perfing MPTCP over very high speed links, shows relevant overhead in mptcp_established_options()

There are number of nested branches there, and we don't have really a fast-path for the most common options set (that is: DSS alone). Additionally we don't really leverage the constraints we have on option size, see:

https://elixir.bootlin.com/linux/latest/source/net/mptcp/options.c#L1347

We need to rewrite mptcp_established_options() carefully sorting the tests to do as little branches as possible when only the DSS is going to be added

@matttbe matttbe changed the title optimze established options generation optimize established options generation Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant