Use r8 for dexing and backporting (MOE 1.x) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r8 fails when the resolve of the super class of "java.lang.Object" returns null. Adding three simple null checks to r8 solves the issue. |
Berstanio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reordered r8 task and validator task so that the validator runs first.
For the moment I didn't changes variable/task names, because it was just a POC. I will do this later.
This currently uses d8, to try to use r8 just replace here and in the sdk publisher all occurence of "d8.jar" with "r8.jar" and adjust line 266 in Proguard.java to use the proguard config. In the moe-core the proguard configs needs to be adjusted that 1. "-ignorewarn" isn't used and 2. "-keepcompanionclasses" needs to be removed.
But r8 will currently fail with a NPE. It seems to be because of the processing of the moe-core.jar, but I don't know why nor have I found some way yet to print debug infos.
Related pr's are: multi-os-engine/moe-sdk-publisher#4, multi-os-engine/moe-tools-classvalidator#2, multi-os-engine/moe-core#4, multi-os-engine/moe-tools_master#3 and multi-os-engine/manifest#2
This fixes multi-os-engine/multi-os-engine#171