Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] AdapterMomentJalaali breaks when selecting date #12794

Closed
Amin-Fathi opened this issue Apr 16, 2024 · 7 comments · Fixed by #13144
Closed

[pickers] AdapterMomentJalaali breaks when selecting date #12794

Amin-Fathi opened this issue Apr 16, 2024 · 7 comments · Fixed by #13144
Assignees
@LukasTy
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization regression A bug, but worse support: docs-feedback Feedback from documentation page

Comments

@Amin-Fathi
Copy link

Amin-Fathi commented Apr 16, 2024 •
edited

Related page

https://mui.com/x/react-date-pickers/calendar-systems/

Kind of issue

Unclear explanations

Issue description

I need example with AdapterMomentJalaali , when use this library i have bug, when open modal calendar and click on the day this day convert to 1 and then not work any thing. Example problem

Screenshot 2024-04-16 111738

@types/moment-jalaali": "^0.7.9",
"moment": "^2.30.1",
"moment-jalaali": "^0.10.0",
"@mui/lab": "^5.0.0-alpha.169",
"@mui/material": "^5.15.14",
"@mui/x-date-pickers": "^7.2.0",

Context

No response

Search keywords: AdapterMomentJalaali
@Amin-Fathi Amin-Fathi added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Apr 16, 2024
@michelengelen
Copy link
Member

@LukasTy I am lost on this one 🤷🏼 Could you maybe provide some info?

@michelengelen michelengelen added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels Apr 16, 2024
@michelengelen michelengelen changed the title AdapterMomentJalaali [pickers] AdapterMomentJalaali breaks when selecting date Apr 16, 2024
@LukasTy
Copy link
Member

LukasTy commented Apr 16, 2024

I am lost on this one 🤷🏼 Could you maybe provide some info?

I haven't investigated it yet.
Firstly, does it work on v6? 🤔

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 17, 2024
@Amin-Fathi
Copy link
Author

Amin-Fathi commented Apr 17, 2024 •
edited

Example:
https://stackblitz.com/edit/vitejs-vite-nw71cx?file=src%2FApp.tsx
@LukasTy @michelengelen 🙏🙏

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Apr 17, 2024
@LukasTy
Copy link
Member

LukasTy commented Apr 17, 2024

@Amin-Fathi @michelengelen I've tracked down that the issue started happening from v6.4.0.
So, it looks like a regression. 🙈

@LukasTy LukasTy added regression A bug, but worse and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 17, 2024
@flaviendelangle
Copy link
Member

I guess the main suspect is #8735 then 😢

@shahlamahdavi68
Copy link

I have exactly this problem !
By selecting a date, it is not possible to change it and it will not work.

@LukasTy LukasTy self-assigned this May 14, 2024
@LukasTy LukasTy mentioned this issue May 15, 2024
Merged
@github-actions GitHub Actions
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@Amin-Fathi: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization regression A bug, but worse support: docs-feedback Feedback from documentation page
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pickers] Fix AdapterMomentJalaali regression LukasTy/mui-x
5 participants
@flaviendelangle @LukasTy @Amin-Fathi @michelengelen @shahlamahdavi68