Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate Limiting #102

Open
maxim123 opened this issue Jun 23, 2017 · 1 comment
Open

Rate Limiting #102

maxim123 opened this issue Jun 23, 2017 · 1 comment

Comments

@maxim123
Copy link

If ≥ n students are signed up on a queue, prevent students from creating a new request during the first t minutes after their previous request has been resolved, so as to prevent students from signing up immediately after they have been helped. Let the course's staff set n and t in the Admin Panel.

@mterwill
Copy link
Owner

I don't think this would be too bad. We could add new columns for n and t on the Course model, along with getters/setters in the admin interface. Then just create a custom validator on CourseQueueEntry, which already stores requester_id and a resolved_at timestamp.

One catch is that there's not currently any error handling on the frontend, so some functionality would need to be added to propagate a useful message up to the end user letting them know why their enqueue was rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants