Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what to do with msys2-runtime tests in this repo #24

Open
2 of 3 tasks
lazka opened this issue Nov 20, 2022 · 3 comments
Open
2 of 3 tasks

Figure out what to do with msys2-runtime tests in this repo #24

lazka opened this issue Nov 20, 2022 · 3 comments

Comments

@lazka
Copy link
Member

lazka commented Nov 20, 2022

It has a copy of the convert code and a bunch of tests.

Suggestion:

@lazka
Copy link
Member Author

lazka commented Nov 20, 2022

It was suggested that we could also make them into unit tests in msys2-runtime. I still think having some integration tests in msys2-tests is still a good idea never the less.

@dscho
Copy link
Contributor

dscho commented Nov 22, 2022

I would love for these tests to be integrated into the msys2-runtime repository. And I agree that the tests would also make sense to be run in the daily msys2-tests runs

One option would be to use this here repository as a submodule for both. But. You know. Submodules. Friends don't let friends use submodules.

Another option I thought about would be to use git subtree. Essentially, this would "merge path_convert into a subdirectory of msys2-runtime.

The option I like best, I think, at least at this moment, is to move the code into msys2-runtime (probably using a singleton git subtree call), archive this here repository, and use a partial clone of msys2-runtime in msys2-tests.

Whatever option we'll end up using, I think we need to consider the consequences well. I, for one, would like to think about this for a while.

@lazka lazka transferred this issue from msys2/path_convert Dec 8, 2022
@lazka lazka changed the title Figure out what to do with this repo Figure out what to do with msys2-runtime tests in this repo Dec 8, 2022
@lazka
Copy link
Member Author

lazka commented Dec 8, 2022

I've moved the relevant code plus this issue to https://github.com/msys2/msys2-tests now, as an intermediate step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants