Please help me building BaCon on MSYS2

[ghost]

This is BaCon: https://www.basic-converter.org/stable/bacon-4.7.tar.gz

The ./configure part is completed without problems but when actually make it failed with:

rm -f build/* build-cpp/*
System error: Windows file detected! Remove non-Unix CR line separators first. Exiting...
make: *** [Makefile:25: bacon] Error 1

[sskras]

On MSYS2 3.4.6 (2023-04-01) it fails in different way:

  ...
checking for flex... yes
checking for indent... no
configure: WARNING: 'indent' was not found on this system - generated sources cannot be indented when preserved.
configure: creating ./config.status
config.status: creating Makefile

Congratulations, all requirements are met!

- Makefile created.
- Using '/usr/bin/ksh' to compile BaCon.
- Creating the legacy BaConGUI for GTK.

Now run 'make' and 'make install' to build and install BaCon.


saukrs@DESKTOP-O7JE7JE MSYS /D/_BACKUPS/src/www.basic-converter.org/stable/bacon-4.7
$ make
rm -f build/* build-cpp/*
objdump: 'cat': No such file
./bacon.sh[120]: typeset: -A: unknown option
./bacon.sh[399]: syntax error: unexpected operator/operand '=~'
make: *** [Makefile:25: bacon] Error 1

Trying to debug:

$ make --trace
Makefile:176: update target 'clean' due to: target does not exist
rm -f build/* build-cpp/*
Makefile:25: update target 'bacon' due to: target does not exist
if [ -n "" ]; then \
        /usr/bin/ksh ./bacon.sh -c "gcc" -o "-g -O2 -fno-var-tracking-assignments" -l "" -d build bacon.bac; \
else \
        /usr/bin/ksh ./bacon.sh -c "gcc" -o "-g -O2 -fno-var-tracking-assignments" -d build bacon.bac; \
fi;
objdump: 'cat': No such file
./bacon.sh[120]: typeset: -A: unknown option
./bacon.sh[399]: syntax error: unexpected operator/operand '=~'
make: *** [Makefile:25: bacon] Error 1

Isolating the failing command line:

$ /usr/bin/ksh ./bacon.sh -c "gcc" -o "-g -O2 -fno-var-tracking-assignments" -d build bacon.bac
objdump: 'cat': No such file
./bacon.sh[120]: typeset: -A: unknown option
./bacon.sh[399]: syntax error: unexpected operator/operand '=~'

KornShell is running Bash script:

$ file bacon.sh
bacon.sh: Bourne-Again shell script, ASCII text executable

$ head -1 bacon.sh
#!/usr/bin/env bash

I haven't investigated where in Makefile make decided to use ksh.
It looks suspicious to me.

[ghost]

I don't have KSH on my MSYS2 so it defaults to Bash. BaCon makes use of associative arrays so it will need a modern version of KSH, though.

[sskras]

Thanks for the idea. After renaming /usr/bin/ksh.exe I get the same error as reported by you.

[sskras]

Cygwin 3.4.6 seems to work better:

saukrs@DESKTOP-O7JE7JE /cygdrive/d/_BACKUPS/src/www.basic-converter.org/stable/bacon-4.7
$ make
rm -f build/* build-cpp/*
Converting 'bacon.bac'... done, 10499 lines were processed in 4975 seconds.
WARNING: neither 'lex' nor 'flex' was found on this system!
Generated binary cannot be optimized.
Compiling 'bacon.bac'... make[1]: Entering directory '/cygdrive/d/_BACKUPS/src/www.basic-converter.org/stable/bacon-4.7/build'
gcc  -g -O2 -fno-var-tracking-assignments -c bacon.bac.c
gcc -o bacon bacon.bac.o    -lm
make[1]: Leaving directory '/cygdrive/d/_BACKUPS/src/www.basic-converter.org/stable/bacon-4.7/build'
bacon.bac.functions.h:41:75: warning: ‘optarg’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]

INFO: see full error report (y/[n])? n
strip build/bacon
Skipping BaConGUI for GTK3.
Skipping BaConGUI for FLTK.
Skipping BaConGUI for TK.
Converting 'gui/bacongui-legacy.bac'... done, 3453 lines were processed in 16.085 seconds.
WARNING: neither 'lex' nor 'flex' was found on this system!
Generated binary cannot be optimized.
Compiling 'gui/bacongui-legacy.bac'... make[1]: Entering directory '/cygdrive/d/_BACKUPS/src/www.basic-converter.org/stable/bacon-4.7/build'
gcc  -g -O2 -fno-var-tracking-assignments -DDATA_PATH=\"/usr/local/share\" -c bacongui-legacy.bac.c
gcc -o bacongui-legacy bacongui-legacy.bac.o -L.    -ldl  -lm
make[1]: Leaving directory '/cygdrive/d/_BACKUPS/src/www.basic-converter.org/stable/bacon-4.7/build'
bacongui-legacy.bac.functions.h:41:75: warning: ‘optarg’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]

INFO: see full error report (y/[n])? n
Run 'make install' or 'sudo make install' to install BaCon on your system.

saukrs@DESKTOP-O7JE7JE /cygdrive/d/_BACKUPS/src/www.basic-converter.org/stable/bacon-4.7
$ uname -a
CYGWIN_NT-10.0-19044 DESKTOP-O7JE7JE 3.4.6-1.x86_64 2023-02-14 13:23 UTC x86_64 Cygwin

[ghost]

So it's working on Cygwin but not MSYS2, even though I'm using the MSYS2 MSYS environment. But, why? Something wrong with MSYS2?

[sskras]

I traced the make run:

$ make --trace
Makefile:176: update target 'clean' due to: target does not exist
rm -f build/* build-cpp/*
Makefile:25: update target 'bacon' due to: target does not exist
if [ -n "" ]; then \
        /bin/bash ./bacon.sh -c "gcc -std=gnu99" -o "-g -O2" -l "" -d build bacon.bac; \
else \
        /bin/bash ./bacon.sh -c "gcc -std=gnu99" -o "-g -O2" -d build bacon.bac; \
fi;
System error: Windows file detected! Remove non-Unix CR line separators first. Exiting...
make: *** [Makefile:25: bacon] Error 1

Seemingly the else branch is failing here.
So I traced it by adding -x to the command line:

$ rm -f build/* build-cpp/*; /bin/bash -x ./bacon.sh -c "gcc -std=gnu99" -o "-g -O2" -d build bacon.bac
+ [[ -n /bin/bash ]]
+ [[ 52 -lt 40 ]]
+ shopt -s extglob
  ...
+ STR=_
+ [[ _ = +(*\[*\]*) ]]
+ [[ -n '' ]]
+ VAR=_
+ g_ALL_MAIN_VARS[${VAR}]=long
++ head -1 bacon.bac
+ [[ '  ____         ____ = +(*) ]]
+ echo 'System error: Windows file detected! Remove non-Unix CR line separators first. Exiting...'
System error: Windows file detected! Remove non-Unix CR line separators first. Exiting...
+ exit 1

That seemingly corresponds to these lines of bacon.sh:

 8536
 8537 # Detect if this is a Windows file
 8538 if [[ `head -1 ${g_FEED}` = +(*${g_CRLF}) ]]
 8539 then
 8540     echo "System error: Windows file detected! Remove non-Unix CR line separators first. Exiting..."
 8541     exit 1
 8542 fi
 8543

Finally I extracted lines that sets g_FEED and g_CRLF and minimized issue down to these 2 lines:

typeset -rx g_CRLF=`echo -e "\015\012"`
echo -n $g_CRLF | od -t x1

Testing results

On Ubuntu 20.04.6 LTS:

sskras@vps1128235:~$ typeset -rx g_CRLF=`echo -e "\015\012"`
sskras@vps1128235:~$ echo -n $g_CRLF | od -t x1
0000000 0d
0000001

On midipix 2022.11.18.20.22.52:

midipix@DESKTOP-O7JE7JE ~
$ typeset -rx g_CRLF=`echo -e "\015\012"`

midipix@DESKTOP-O7JE7JE ~
$ echo -n $g_CRLF | od -t x1
0000000 0d
0000001

On Cygwin 3.4.6-1:

saukrs@DESKTOP-O7JE7JE ~
$ typeset -rx g_CRLF=`echo -e "\015\012"`

saukrs@DESKTOP-O7JE7JE ~
$ echo -n $g_CRLF | od -t x1
0000000 0d
0000001

On MSYS2 3.4.6:

saukrs@DESKTOP-O7JE7JE MSYS ~
$ typeset -rx g_CRLF=`echo -e "\015\012"`

saukrs@DESKTOP-O7JE7JE MSYS ~
$ echo -n $g_CRLF | od -t x1
0000000

On MSYS2 the variable seems to be empty.
That's the difference / a bug.

It could be reported on msys2/msys2-runtime, I think.
And the testing lines could go into msys2/msys2-tests, I guess.