Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe someone forgot -mwindows? #20519

Closed
3 of 7 tasks
iahung3 opened this issue Apr 1, 2024 · 10 comments · Fixed by #20545
Closed
3 of 7 tasks

Maybe someone forgot -mwindows? #20519

iahung3 opened this issue Apr 1, 2024 · 10 comments · Fixed by #20545
Labels
bug reported-upstream Issues reported or fixed in upstream repository

Comments

@iahung3
Copy link
Contributor

iahung3 commented Apr 1, 2024

Description / Steps to reproduce the issue

evince.exe and geany.exe always come with a command prompt window

Expected behavior

They are graphical application. There should be no command prompt window

Actual behavior

There is always a command prompt window when open these applications

Verification

Windows Version

MINGW64_NT-10.0-19045

MINGW environments affected

  • MINGW64
  • MINGW32
  • UCRT64
  • CLANG64
  • CLANG32
  • CLANGARM64

Are you willing to submit a PR?

No

@Kreijstal
Copy link
Contributor

Kreijstal commented Apr 2, 2024

You can just call & at the end of the command, if it annoys you having to do that just do a bash shim that does it for you

@iahung3
Copy link
Contributor Author

iahung3 commented Apr 2, 2024

You can just call & at the end of the command, if it annoys you having to do that just do a bash shim that does it for you

I don't launch them from MSYS2 shell. I clicked into the binaries directly.

@Biswa96
Copy link
Member

Biswa96 commented Apr 2, 2024

I have fixed this issue locally by adding win_subsystem: 'windows' in meson file and try to upstream the changes first.

@Biswa96
Copy link
Member

Biswa96 commented Apr 3, 2024

This upstream pull request will fix the issue geany/geany#3811

@Biswa96 Biswa96 added the reported-upstream Issues reported or fixed in upstream repository label Apr 3, 2024
@ognevny
Copy link
Collaborator

ognevny commented Apr 3, 2024

This upstream pull request will fix the issue geany/geany#3811

I think you can backport it now. in case they don't accept just create the patch file with these change (or edit existing patch for meson.build)

@Biswa96
Copy link
Member

Biswa96 commented Apr 3, 2024

I shall wait for some time. Also, there are two changes needed - adding resource file and /s/WIN32/_WIN32 in ctags.

@ognevny
Copy link
Collaborator

ognevny commented Apr 3, 2024

I shall wait for some time. Also, there are two changes needed - adding resource file and /s/WIN32/_WIN32 in ctags.

currently meson.build is patched to define WIN32

@Biswa96
Copy link
Member

Biswa96 commented Apr 3, 2024

currently meson.build is patched to define WIN32

I meant to upstream the change first. Also, that is a workaround != fix.

@iahung3
Copy link
Contributor Author

iahung3 commented Apr 4, 2024

@Biswa96 You forgot evince.exe: #19723 (console window popup), #20537 (missing icon). gedit.exe doesn't have a console window popup but it's also missing icon: #20526

@Biswa96
Copy link
Member

Biswa96 commented Apr 4, 2024

See the comment in gedit thread. Those need more work in upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reported-upstream Issues reported or fixed in upstream repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants