Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory allocation in EXT32 #329

Open
WernherVonData opened this issue Jul 27, 2023 · 0 comments
Open

Memory allocation in EXT32 #329

WernherVonData opened this issue Jul 27, 2023 · 0 comments

Comments

@WernherVonData
Copy link

Hello, I was debugging the decoding code and get some thought regarding EXT32 format: is it necessary to allocate the table of 2^32-1 bytes ad hoc before reading the rest of the bytes?

What if the data payload will be just few bytes? The allocation is done earlier and over 1GB of memory is used on JVM - that is a waste. Such approach open potential vulnerability on client side of the library that message this kind will be passed. Was such concern was thought earlier? Is it responsibility on the client side to "know" what is he going to decode? Don't know if someone else see this situation in a similiar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant