Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last modified in spec.md is out of date #319

Open
jsoref opened this issue May 13, 2022 · 0 comments
Open

Last modified in spec.md is out of date #319

jsoref opened this issue May 13, 2022 · 0 comments

Comments

@jsoref
Copy link

jsoref commented May 13, 2022

In #170 (comment), there was this throwaway note:

By the way, the date of "Last modified" is not updated.

https://github.com/msgpack/msgpack/blob/9aa092d6ca81f12005bd7dcbeb6488ad319e5133/spec.md

@timmc Correct "fixnum" to "fixint" in new spec (to match rest of document) … Latest commit 9aa092d on Apr 28, 2021
History

image
image

MessagePack specification
Last modified at 2017-08-09 22:42:07 -0700
Sadayuki Furuhashi © 2013-04-21 21:52:33 -0700

Having a last-modified dating to 2017, when in fact the file was changed in 2021 is quite confusing.

I'd personally suggest removing the line, or replacing it with a note to see the git blame or something.

I don't see a code of conduct or a template or anything, so I'm not going to make a PR unless someone indicates they're willing to accept such a change. I'd be willing to make a PR as it would be trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant