Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsgFlo coordinator didn't stop participant when clearing and re-sending graph #131

Open
bergie opened this issue May 10, 2017 · 3 comments

Comments

@bergie
Copy link
Member

bergie commented May 10, 2017

Viewing MsgFlo in Flowhub live mode, switching to edit mode: as result we have two running instances of msgflo-register-foreign with same role:

├─702 node ./node_modules/.bin/msgflo-register-foreign participants/panel.yml --role weltenbaulab --forever=true
├─828 node ./node_modules/.bin/msgflo-register-foreign participants/panel.yml --role weltenbaulab --forever=true
@jonnor jonnor added the bug label May 31, 2017
@jonnor
Copy link
Member

jonnor commented May 31, 2017

How reproducable is this? How to reproduce?

@bergie
Copy link
Member Author

bergie commented May 31, 2017

@jonnor my gut feel (on Linux), this is quite random ... sometimes all participants stop, and sometimes some of them are left running.

To reproduce you'd have to start the coordinator (which then starts some participants), stop it, start again a few times and see if there are any lingering processes.

I'm seeing this also when running the MsgFlo test suite locally. If I just npm test, I seem to have about 50% chance that there are some Node.js processes left around after the test suite finishes.

@jonnor
Copy link
Member

jonnor commented Jun 2, 2017

The msgflo test suite does even attempt to clean after itself. But we don't double fork, so I'm suprised that the processes would survive...

Anyways, next time it happens, can you provide also pstree -s -p $PID - where $PID is the process id of one of the participants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants