Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release for GH and NPM #56

Open
lovato opened this issue Jan 21, 2020 · 2 comments
Open

New release for GH and NPM #56

lovato opened this issue Jan 21, 2020 · 2 comments

Comments

@lovato
Copy link
Collaborator

lovato commented Jan 21, 2020

Hi @mserranom . I think I got all access to everything.
On NPM the organization, for me, is empty.

There is the release.sh script, which I would assume to run locally to get something released to GH.
You also have Travis config file.

Can I think if GitHub actions, from Master, calling all steps AND releasing the package to NPMJS?
One thing I ended using in a few Node projects was to set the package.json version ONLY when releasing (like it was 1.0.0 and at release time become 1.0.20200120) and never push this back to the repo. Instead, just tag the repo with v1.0.20200120. Everything gets automatic then, and releases can be fully automatic from GH itself. Travis would not be needed anymore (or use Travis and forget GH).

What do you think? I would like to have latest master released to NPMJS.

Best
Marco

@lovato
Copy link
Collaborator Author

lovato commented Jan 21, 2020

Btw, trying octobox.

@mserranom
Copy link
Owner

Added the package to the organisation, it threw errors when I tried last time, but seems fixed now. Let me know if there's any issue!

The release.sh script does create a published package in npmjs.org, feel free to release a new version. Regarding the change in the process, I'm always up for more automation.

Travis file can be deleted, builds are already configured to run as github actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants