Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --keepContainerRunning option #35

Open
mserranom opened this issue Jul 17, 2018 · 2 comments
Open

add --keepContainerRunning option #35

mserranom opened this issue Jul 17, 2018 · 2 comments

Comments

@mserranom
Copy link
Owner

mserranom commented Jul 17, 2018

Currently docker commands are run with --rm option, that destroys the container after execution.

A --keep-container will not destroy the containers, which is useful for debugging purposes.

@vijayakumark
Copy link

to make it consistent with other options, I would suggest keeping the option name in all lower case separated by hyphen. Also considering that by the time script finishes the container may have stopped even without --rm , we may want to name the option --keep-container .

When --keep-container option is passed we could skip removing container, effectively keeping it in a stopped state.

@mserranom
Copy link
Owner Author

thanks @vijayakumark, updated

gjedeer added a commit to gjedeer/bbrun that referenced this issue Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants