Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstream url #232

Closed
wants to merge 4 commits into from
Closed

Conversation

kingsleyadam
Copy link

To Fix #231. Move the upstream URL from the plexupdate-core to the plexupdate.sh script as it needs config variables which are not sources in plex update-core

Adam Kingsley and others added 4 commits March 17, 2018 22:05
…specified in the /etc/plexupdate.cron.conf file.
Add a method to send a slack message and call it if a webhook url is …
… url is specified in the /etc/plexupdate.cron.conf file."

This reverts commit 2a0ea34.
@kingsleyadam
Copy link
Author

There's a lot of extra commits due to my mistakes. If you want I can scrap this and start a new fork completely.

@demonbane
Copy link
Collaborator

Have you seen this actually happen? plexupdate-core gets sourced well before UPSTREAM_GIT_URL is ever referenced, so it should work just fine.

And don't worry about having too many commits, that's what squash and merge is for. It'll take all of the commits and condense them down to a single commit when it gets merged to master.

@demonbane demonbane closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix update check for custom repositories
2 participants