Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the start/end time for an existing entry is modified, nanoseconds portion left out #3

Open
khughitt opened this issue Feb 5, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@khughitt
Copy link
Contributor

khughitt commented Feb 5, 2021

When the start or end time is modified for an existing entry (e.g. zeit entry --finish xx), the updated time is stored without the nanoseconds portion, potentially leading to issues when parsing the output from zeit export.

Version info:

  • zeit commit #ab78ffcd006405051b057be1f25d5b9c16ee0b66
@mrusme mrusme added the bug Something isn't working label Feb 6, 2021
@mrusme
Copy link
Owner

mrusme commented Feb 7, 2021

@khughitt not exactly sure how to solve this issue, since it's more like a user-entry error. If a user specifies every detail in RFC3339 format, then it's being stored correctly:

zeit entry --begin "2021-02-07T11:11:12.917391-04:00" e2b9ac6d-2b57-41e3-9069-db308582d991

It's also questionable whether nanoseconds are actually relevant for time entries. So maybe the fix would be to remove this info altogether?

@khughitt
Copy link
Contributor Author

khughitt commented Feb 9, 2021

@mrusme Ah okay, I was following the example from the README, which doesn't include nanoseconds in the time specification, and hence, I the updated entry didn't have them either.

In any case, I think you are right though -- personally, I can't imagine ever needing something better than ~1 minute resolution. We can save the nanosecond resolution tracking for some future dystopian corporate world >.<.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants