Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly classes #217

Open
hakubo opened this issue Mar 29, 2023 · 3 comments
Open

Readonly classes #217

hakubo opened this issue Mar 29, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hakubo
Copy link

hakubo commented Mar 29, 2023

I saw that sometime ago you added #103 readonly classes, but it got never merged.

Any chance that you'd accept a PR for this? With added 'readonly' option, so users can configure it?

@mrmckeb
Copy link
Owner

mrmckeb commented Apr 10, 2023

hi @hakubo, I'll be honest, I can't remember why we didn't go ahead with that PR now. It's unfortunate that I didn't make a note at the time - sorry about that. I know we hit some issues with const/let at the time (See: #97), so it's possible that it was related to that, or it could be that I just ran short of time.

I'm more than happy for you to add it. It might be easier to use the Readonly<Type> utility.

I'm not sure that it needs to be an option. I was playing around then and I can't think of any risks - but very open to feedback/thoughts on that.

@mrmckeb mrmckeb added the enhancement New feature or request label Apr 10, 2023
@OlaoluwaM
Copy link

Hi! First off, love the project. Awesome work! Second, having all the properties be readonly makes a lot of sense and would love to try my hand at adding it

@mrmckeb mrmckeb added the help wanted Extra attention is needed label Sep 22, 2023
@mrmckeb
Copy link
Owner

mrmckeb commented Sep 22, 2023

@OlaoluwaM, that would be a welcome addition - thanks. Obviously it wouldn't apply to named imports and only style objects, but I definitely think those should be readonly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants