Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualMatrixPanel::_virtualResX - Not initialized when using NO_GFX #594

Open
netmindz opened this issue Feb 24, 2024 · 1 comment
Open

VirtualMatrixPanel::_virtualResX - Not initialized when using NO_GFX #594

netmindz opened this issue Feb 24, 2024 · 1 comment

Comments

@netmindz
Copy link

VirtualMatrixPanel::getCoords expects to use _virtualResX and _virtualResY to be defined, but these are only defined by VirtualMatrixPanel::setRotation which is not called by default

You can work around the issue by calling fourScanPanel->setRotation(0); otherwise, you just get no output
@mrcodetastic
Copy link
Owner

mrcodetastic commented Feb 25, 2024 •
edited

Thank you for finding this. If you have a suggested fix, please feel free to raise a pull request, and I'll merge.

Lukaswnd added a commit to Lukaswnd/ESP32-HUB75-MatrixPanel-DMA that referenced this issue Mar 18, 2024
@Lukaswnd
Update ESP32-VirtualMatrixPanel-I2S-DMA.h
a2b7559 
fix issue mrcodetastic#594
did not check any further Problems
@Lukaswnd Lukaswnd mentioned this issue Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netmindz @mrcodetastic