Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not be compatible for substeam dependency using Carthage #12

Open
dreampiggy opened this issue Nov 27, 2019 · 1 comment
Open

Can not be compatible for substeam dependency using Carthage #12

dreampiggy opened this issue Nov 27, 2019 · 1 comment

Comments

@dreampiggy
Copy link

dreampiggy commented Nov 27, 2019 •
edited

This is because if you need to dependent another framework A.

Carthage will build A with the following structure:

Carthage/Build/iOS/A.framework
Carthage/Build/Mac/A.framework
Carthage/Build/tvOS/A.framework
Carthage/Build/watchOS/A.framework

But, you can not change the Linked library or framework with xcconfig, it supports only one file path. Not related to any configuration.

You have to use 4 different targets for this. Suck here.

This is what we SDWebImge components faced issues. The only way to achice one tatget for all platforms, it’s to drop Carthage at all.
@dreampiggy
Copy link
Author

dreampiggy commented Nov 27, 2019 •
edited

Our SDWebImage already use Only one target, because it does not have any dependency. However, suck for the substream dependency.

See all our effected frameworks who have to support Carthage:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dreampiggy