Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For coronagraph masks, add "bar_offset_y" for NIRCam. Add similar for the round occulters and MIRI as well. #191

Open
mperrin opened this issue Feb 19, 2018 · 3 comments

Comments

@mperrin
Copy link
Owner

mperrin commented Feb 19, 2018

As requested by @ariedel for use in Pandeia ETC coronagraph generation script

@ariedel
Copy link

ariedel commented Feb 19, 2018

Use case is that Pandeia requires the PSF to be centered on a pixel; this currently requires us to snap to pixel positions rather than the actual requested XY location.

@mperrin
Copy link
Owner Author

mperrin commented Feb 19, 2018

This turns out to be a real pain in the neck for MIRI, given the different rotated coordinate systems. Because of how the optics are implemented, the "natural" way to offset the FQPM is in V2V3, rotated by ~ 5 deg from the instrument detector X and Y (which is what Pandeia wants to work in). So even implementing a "simple" option to offset the focal plane mask by a given amount inevitable is going to involve some coordinate transforms. Not hard, just more work.

NIRCam's comparatively simple.

@mperrin
Copy link
Owner Author

mperrin commented Apr 27, 2018

@ariedel, remind me where we left things with the coronagraph PSF generation script. I have this open issue about adding an option for shifting the masks around, and added code back in February to implement it. I'm not sure if any more is needed now? If you're happy with the coronagraph PSF generation script then good and I won't worry about any more effort on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants