Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for OpenCV 2, 3 and 4 #88

Open
kopetri opened this issue Oct 7, 2019 · 1 comment
Open

Check for OpenCV 2, 3 and 4 #88

kopetri opened this issue Oct 7, 2019 · 1 comment

Comments

@kopetri
Copy link

kopetri commented Oct 7, 2019

Since there are multiple versions of opencv available, you should change your version tests cv2.__version__.split(".")[0] == '3' to something like int(cv2.__version__.split(".")[0]) >= 3

@mpatacchiola
Copy link
Owner

Hi @kopetri you are right, however at the moment we have not tested if everything is fine when using OpenCV > 3, therefore we cannot guarantee the correct functioning of the library.

If you want to contribute you are more than welcome to check if everything runs smoothly and send a pull request with the updated flag in all files. This should not take too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants