Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid geneal-case division and modulus in _ntoa functions #117

Open
eyalroz opened this issue Aug 1, 2021 · 0 comments
Open

Avoid geneal-case division and modulus in _ntoa functions #117

eyalroz opened this issue Aug 1, 2021 · 0 comments

Comments

@eyalroz
Copy link

eyalroz commented Aug 1, 2021

@mickjc750 suggests:

In the ntoa(), I'd recommend using literal values %2 %8 %10 %16 rather than
%base, as it saves performing a division. It's a minor size increase for a
big performance increase.

Sounds like a plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant