Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError: 'private': remove private key requirement from bugbot/round_robin.py #2388

Open
benjaminmah opened this issue May 8, 2024 · 0 comments

Comments

@benjaminmah
Copy link
Contributor

benjaminmah commented May 8, 2024

Currently in bugbot/round_robin.py under the class RotationDefinitions, we retrieve the private key from config.json. We do not require that and thus should be removed.

https://github.com/mozilla/bugbot/blob/master/bugbot/round_robin.py#L221

2024-05-08 13:52:50,200 - INFO - Run rule triage_owner_rotations.py
2024-05-08 13:52:50,203 - CRITICAL - Uncaught exception
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/bugbot/bugbot/rules/triage_owner_rotations.py", line 104, in <module>
    TriageOwnerRotations().run()
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bugbot/bugbot/rules/triage_owner_rotations.py", line 38, in __init__
    self.component_triagers = ComponentTriagers(excluded_teams=excluded_teams)
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bugbot/bugbot/component_triagers.py", line 30, in __init__
    self.round_robin: RoundRobin = RoundRobin.get_instance()
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bugbot/bugbot/round_robin.py", line 43, in get_instance
    RoundRobin._instances[None] = RoundRobin()
                                  ^^^^^^^^^^^^
  File "/home/bugbot/bugbot/round_robin.py", line 30, in __init__
    RotationDefinitions()
  File "/home/bugbot/bugbot/round_robin.py", line 221, in __init__
    self.definitions_url = utils.get_private()["round_robin_sheet"]
                           ^^^^^^^^^^^^^^^^^^^
  File "/home/bugbot/bugbot/utils.py", line 158, in get_private
    return json.load(In)["private"]
           ~~~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'private'
@benjaminmah benjaminmah changed the title Remove private key requirement from bugbot/round_robin.py KeyError: 'private': remove private key requirement from bugbot/round_robin.py May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant