Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit allows inconsistent mix between tab and space indentation in JSON files #2332

Open
PromiseFru opened this issue Jan 26, 2024 · 2 comments

Comments

@PromiseFru
Copy link
Collaborator

The check-json hook from pre-commit/pre-commit-hooks currently does not address the issue of inconsistent mixing between tab and space indentation within the JSON content. This can lead to potential problems, as mixing tabs and spaces for indentation is generally not recommended for JSON files.

bugbot/configs/rules.json

Lines 422 to 426 in d26e6fa

"performancebug": {
"max_days_in_cache": 7,
"days_lookup": 7,
"confidence_threshold": 0.9
},

@nox1134
Copy link

nox1134 commented Jan 28, 2024

Hi @suhaibmujahid! I'd like to work on this issue.

@suhaibmujahid
Copy link
Member

I'd like to work on this issue.

@nox1134 feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants