P1 affecting or may affect does not list all P1 affecting a given version.

[nbp]

Currently the list of P1 does not make much sense:

1. We check the status flag against ---,?, while these are the values of the tracking flags.
   Problem: This condition will always be false.
2. We include any bug which has a creation date newer than the mergedate, which corresponds to the day the branch is created.
   Problem: This might be what the "may affect" is meant to be, but it causes to filter out any P1 affecting previous version. i.e. P1 affecting 60 will not be listed in the list of P1 affecting 61, because the status flags are not automatically propagated from one version to the next.

I suggest to modify this search such that we include any P1 opened before branching to beta. Thus converting the condition to:

ANY(
  ${"cf_status_" + versionStr} == affected
  ALL(
    ${"cf_status_" + versionStr} is-empty
    creation_ts <= ${betadate}
  )
)

This will remove the "may affect" aspect of the query, but this will include all P1 affecting a given version.

[nbp]

Note, the previous code sample would literally be the fix for this issue once #36 is merged.

[emceeaich]

I went back to the underlying bugzilla query (above), and we're including two groups of bugs:

• Any P1 bug currently open that has status affected for the release (known affected)
• Any P1 bug opened on or after the start of the release cycle for which we haven't made a decision on for this release (may affect)

We are checking the status, and not the tracking flags here and ? and --- are valid values for status flags.

There's an argument for removing the date restriction on P1 bugs which haven't been checked to see if they affect the release, and that would be a way to encourage triagers to check their use of P1.

As of today there are 806 bugs affecting or which may affect Firefox 62. If we remove the date restriction, that becomes 875 bugs (there are 896 P1s in Firefox components which aren't meta or enhancements).

This is more of an issue with older P1s, which need re-assessment, re-prioritization or WONTFIX'ing.