Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pocket Share Experiment #20145

Open
data-sync-user opened this issue May 3, 2024 · 3 comments
Open

Remove Pocket Share Experiment #20145

data-sync-user opened this issue May 3, 2024 · 3 comments

Comments

@data-sync-user
Copy link
Collaborator

This experiment has been disabled for a long time now and the experiment concluded there was no evidence for improvements.

Removing it to clean up the codebase.

https://docs.google.com/document/d/1AZY6dkG6OYBU-w7YYdkBtwnsPiGaOHlCZP2BqzQG_pQ/edit#heading=h.kzffe2a93ndd

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator Author

➤ Alina Moldovan commented:

Sophie Amin Could you please add some details for the QA team to know what to test?

@data-sync-user
Copy link
Collaborator Author

➤ Sophie Amin commented:

Alina Moldovan You can see the linked document for details one what the experiment was.

I removed the share icon in the toolbar when the experiment was enabled (so check toolbar/url bar function)

And the long press context menu options have been reverted back to their original state from before this experiment.

Send to device should only be available from the hamburger menu now.

Here’s the PR with additional details #20173 (review) ( https://github.com/mozilla-mobile/firefox-ios/pull/20173#pullrequestreview-2048188316|smart-link )

!simulator_screenshot_3F3EEEA7-7016-4727-84E4-DE24A42F88B6.png|width=1179,height=2556,alt="simulator_screenshot_3F3EEEA7-7016-4727-84E4-DE24A42F88B6.png"!

@data-sync-user
Copy link
Collaborator Author

➤ Donal Meehan commented:

This is currently planned to ship with 126.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant