Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Fiddle functionality #637

Closed
aarthificial opened this issue May 4, 2023 · 0 comments · Fixed by #642
Closed

Improve Fiddle functionality #637

aarthificial opened this issue May 4, 2023 · 0 comments · Fixed by #642
Assignees
@aarthificial
Labels
a-docs Relates to the docs package b-enhancement New feature or request c-accepted The issue is ready to be worked on

Comments

@aarthificial
Copy link
Contributor

Description
The current fiddle implementation is not suitable for all use cases.

Proposed solution
The functionality should be expanded with the following:

  • a property controlling the ratio of the preview.
  • a layout switch:
    • code only (displayed as a simple CodeBlock)
    • code + preview
    • preview only

Additional context
Blocks #618
@aarthificial aarthificial added b-enhancement New feature or request c-accepted The issue is ready to be worked on a-docs Relates to the docs package labels May 4, 2023
@aarthificial aarthificial self-assigned this May 4, 2023
@aarthificial aarthificial mentioned this issue May 4, 2023
Draft
aarthificial added a commit to aarthificial/motion-canvas that referenced this issue May 5, 2023
@aarthificial
feat(docs): improve Fiddle functionality
1a67a8b 
Fiddles now support two additional properties:
- `ratio` - the aspect ratio of the preview
- `mode` - the default layout to use

Fiddles can be toggled between the three following modes:
- `code` - is rendered like a standard CodeBlock
- `editor` - and editor with a preview at the top
- `preview` - only the preview without the code

Users can switch between modes using a toolbar in the top right corner.

Closes: motion-canvas#637
aarthificial added a commit to aarthificial/motion-canvas that referenced this issue May 5, 2023
@aarthificial
feat(docs): improve Fiddle functionality
4a69599 
Fiddles now support two additional properties:
- `ratio` - the aspect ratio of the preview
- `mode` - the default layout to use

Fiddles can be toggled between the three following modes:
- `code` - is rendered like a standard CodeBlock
- `editor` - and editor with a preview at the top
- `preview` - only the preview without the code

Users can switch between modes using a toolbar in the top right corner.

Closes: motion-canvas#637
aarthificial added a commit to aarthificial/motion-canvas that referenced this issue May 5, 2023
@aarthificial
feat(docs): improve Fiddle functionality
9fcbbcc 
Fiddles now support two additional properties:
- `ratio` - the aspect ratio of the preview
- `mode` - the default layout to use

Fiddles can be toggled between the three following modes:
- `code` - is rendered like a standard CodeBlock
- `editor` - and editor with a preview at the top
- `preview` - only the preview without the code

Users can switch between modes using a toolbar in the top right corner.

Closes: motion-canvas#637
@aarthificial aarthificial mentioned this issue May 5, 2023
Merged
aarthificial added a commit that referenced this issue May 5, 2023
@aarthificial
feat(docs): improve Fiddle functionality (#642)
fd3d6b3 
Fiddles now support two additional properties:
- `ratio` - the aspect ratio of the preview
- `mode` - the default layout to use

Fiddles can be toggled between the three following modes:
- `code` - is rendered like a standard CodeBlock
- `editor` - and editor with a preview at the top
- `preview` - only the preview without the code

Users can switch between modes using a toolbar in the top right corner.

Closes: #637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarthificial aarthificial

Labels
a-docs Relates to the docs package b-enhancement New feature or request c-accepted The issue is ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docs): improve Fiddle functionality aarthificial/motion-canvas
1 participant
@aarthificial