Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change width and height parameter type from number to responsive value per react standard. #399

Open
zxkeyy opened this issue Sep 1, 2023 · 1 comment
Open

Change width and height parameter type from number to responsive value per react standard. #399

zxkeyy opened this issue Sep 1, 2023 · 1 comment

Comments

@zxkeyy
Copy link

zxkeyy commented Sep 1, 2023

Currently accepts

  • width={999}

Needs to accept

  • width="50%"
  • width="100px"
  • width="full"
  • ...etc
@zxkeyy zxkeyy changed the title Change width and height from number to responsive value per react standard. Change width and height parameter type from number to responsive value per react standard. Sep 1, 2023
@mosch
Copy link
Owner

mosch commented Sep 5, 2023

Great suggestion, pr welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mosch @zxkeyy