Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Validate proxies list before protocol decoder #6

Open
getlarge opened this issue Dec 4, 2019 · 6 comments
Open

[feat] Validate proxies list before protocol decoder #6

getlarge opened this issue Dec 4, 2019 · 6 comments

Comments

@getlarge
Copy link
Member

getlarge commented Dec 4, 2019

Would you mind removing this todo and opening an issue instead?

Originally posted by @mcollina in moscajs/aedes#334

@robertsLando robertsLando changed the title Validate proxies list before protocol decoder [feat] Validate proxies list before protocol decoder Jan 23, 2020
@robertsLando
Copy link
Member

@getlarge Would you mind to submit a PR for this?

@getlarge
Copy link
Member Author

Yes i might make a proposal next week.
By the way, there is still an issue in the with the protocol decoder when Aedes broker is used behind a TCP proxy which handles SSL termination.
The packet is splitted in two, on one side the protocol proxy header and the TCP buffer on the other.
Any help to solve this would be appreciated.

@robertsLando
Copy link
Member

robertsLando commented Jan 23, 2020 via email

@robertsLando
Copy link
Member

@getlarge should this be moved to aedes-server-factory or protocol decoder libs instead?

@getlarge
Copy link
Member Author

Good question, protocol-decoder might be a better place. We could still reuse that logic inside the server-factory via an option that could be overridden by user like protocolDecoder, serverFactory.

@robertsLando robertsLando transferred this issue from moscajs/aedes Oct 26, 2020
@robertsLando
Copy link
Member

Moved to protocol decoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants