New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Header types are public and so are New<TypeName> ? #145

Open

wadearnold opened this issue Nov 23, 2021 · 1 comment

Labels

question

Member

wadearnold commented Nov 23, 2021 •

edited

I was wondering why the network header types are exported along with the creation of them?

Here the type is exported
type Binary2Bytes struct {

And then the instantiation of it is also exported?
func NewBinary2BytesHeader() *Binary2Bytes {

Any reason to have the type exported? When would I use one over the other? Does this need to be documented?

Contributor

alovak commented Jun 29, 2023

Should we move the headers to https://github.com/moov-io/iso8583-connection as it seems a more relevant place for them?

I also think we don't need a constructor here, but we also should not export Len -> len as well.

adamdecaf added the question label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment