Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the Header interface with Name() #267

Closed

Conversation

PumpkinSeed
Copy link
Contributor

Resolve #144

  • Added the Name() method for the Header interface
  • Implement the missing method for the structs implement the Header

@alovak
Copy link
Contributor

alovak commented Aug 29, 2023

@PumpkinSeed May I ask you to share some context about your use case for headers and Name?

I'm asking because I think that we should move headers into https://github.com/moov-io/iso8583-connection -> headers package

@PumpkinSeed
Copy link
Contributor Author

Well, I opened the issue board and I saw the #144. So I thought I resolve this issue by adding this. That's my use-case for now. I'm just trying to understand the library, because we have a basic iso8583 package. I think the best way to understand something is via contributions.

@alovak
Copy link
Contributor

alovak commented Aug 30, 2023

@PumpkinSeed thanks for the context! I had to close that ticket so no one would take it. Sorry.

this package is focused on message building and parsing. For networking, which includes headers, we have a separate repository https://github.com/moov-io/iso8583-connection. So, I want to move headers there. But it will be a breaking change... so I tried to postpone it...

@PumpkinSeed
Copy link
Contributor Author

Make sense, thanks for the update.

@PumpkinSeed PumpkinSeed deleted the I144-extend-header-interface branch August 30, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header interface() should include Name()
2 participants