Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump for L8 #33

Open
skipworkgh opened this issue Nov 12, 2020 · 16 comments
Open

Version bump for L8 #33

skipworkgh opened this issue Nov 12, 2020 · 16 comments

Comments

@skipworkgh
Copy link

Can we please get a new version bump, so that L8 is supported? Thanks!

@chrispage1
Copy link

@skipworkgh looks like it's compatible with 8 :)

@skipworkgh
Copy link
Author

skipworkgh commented Nov 28, 2020

The current released version does not suppert L8 just yet. Hence my question for a new version.

@chrispage1
Copy link

Ah apologies - I was looking at the 2.x branch which does have the version bumps. I'd imagine that is all that's needed, maybe worth forking and testing it out?

@skipworkgh
Copy link
Author

It is working as far as I've tested it. Without a version bump of this package however, it's impossible to include the L8 changes using composer.

@cyrossignol
Copy link
Member

Sorry for the delay. My GitHub email notifications were not arriving. I thought that we finalized Laravel 8 support on the 2.x branch, but it looks like it was never tagged. I will push a release today.

Side note: for those who want to test development branches, we can set 2.x-dev as the version constraint for this package.

@skipworkgh
Copy link
Author

@cyrossignol is there any particular reason why the new release isnt pushed yet?

@GytisT
Copy link

GytisT commented Dec 10, 2020

@cyrossignol @skipworkgh really looking forward to this to be able to upgrade to Laravel 8.0 in a straight forward way.

@mbalandis
Copy link

Still waiting :)

@krzysztof-wojcik-ig
Copy link

Hi @cyrossignol Could you please release that version? ;)

@kristopher1
Copy link

Hi, @jacovdbergh @pdbreen @yupmin-ct Could you please release L8 version? ;)

@ikari7789
Copy link

Hi @cyrossignol,

I understand that we all become quite busy, but it's been over a year since you mentioned "pushing a release today."

Has there been any progress on this? I'd like to be able to not have to refer to the "-dev" branch in my projects.

@mbalandis
Copy link

mbalandis commented Jan 6, 2022

@ikari7789 If you want feel free to use this: https://github.com/sharpstream/laravel-redis-sentinel-drivers or fork youself. This dev ain't releasing it and I was fed up waiting.
I tried it works fine in production on the latest code. Nothing has been altered.

@DreadfulCode
Copy link

It's now August of 2022, still no working sentinel configuration for Laravel v8, does not work with PHPredis driver. Is this package deprecated?

@krzysztof-wojcik-ig
Copy link

Hi @DreadfulCode it is possible to configure Redis sentinel in Laravel v8 without that library.

@ikari7789
Copy link

Hi @krzysztof-wojcik-ig could you be so kind as to provide an example of how to configure it? I haven't seen any mention of it in the official Laravel docs.

@krzysztof-wojcik-ig
Copy link

Here you can find example config for it: https://maxinterview.com/code/laravel-redis-sentinel-30DB90D4DAFEC86/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants