Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer_copy_mono reverse behavior with overlapping regions #1653

Open
catfact opened this issue Feb 14, 2023 · 0 comments
Open

buffer_copy_mono reverse behavior with overlapping regions #1653

catfact opened this issue Feb 14, 2023 · 0 comments

Comments

@catfact
Copy link
Collaborator

catfact commented Feb 14, 2023

this might be known behavior that just needs clarification, idk.

reported on lines:
https://llllllll.co/t/norns-2-0-softcut/20550/281

i'm not exactly clear on what is going on but it seems like maybe unintended results are happening when destination overlaps source (such as attempting to reverse in place.) or maybe it is known that the operation will be truncated as needed in order not to allocate working memory.

that logic is here:
https://github.com/monome/norns/blob/main/crone/src/BufDiskWorker.cpp#L253-L279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant