Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Velocity recorded as actions in sample channels is not sample-accurate #683

Open
tblrchstr opened this issue Jan 30, 2024 · 0 comments
Open

Velocity recorded as actions in sample channels is not sample-accurate #683

tblrchstr opened this issue Jan 30, 2024 · 0 comments
Assignees
@tblrchstr @gvnnz
Labels
bug
Milestone
1.future

Comments

@tblrchstr
Copy link
Collaborator

Environment

  • OS: all
  • Giada version: 0.26.1

Describe the bug
The velocity always change at the beginning of the audio block, because of this line where velocity is applied as gain to the whole block. We should add an extra "offset" parameter to determine the right sample where the velocity change should be applied.
@tblrchstr tblrchstr added the bug label Jan 30, 2024
@tblrchstr tblrchstr added this to the 1.future milestone Jan 30, 2024
@tblrchstr tblrchstr changed the title Velocity changes recorded as actions in sample channels are not sample-accurate Velocity recorded as actions in sample channels is not sample-accurate Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tblrchstr tblrchstr

@gvnnz gvnnz

Labels
bug
Projects
None yet
Milestone
1.future
Development

No branches or pull requests
2 participants
@tblrchstr @gvnnz