Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Corrupted UnknownBox data #352

Open
LeadAssimilator opened this issue Apr 8, 2024 · 0 comments
Open

[BUG] Corrupted UnknownBox data #352

LeadAssimilator opened this issue Apr 8, 2024 · 0 comments

Comments

@LeadAssimilator
Copy link

21d46df corrupts UnknownBox data.

This change causes garbage data fields for unknown boxes and should be reverted. BoxHeader reads more than it should (intentionally it seems) and relies on LoadData to seek back to the proper place to correct it. But since that is no longer called, the file position remains too far forward and the read data winds up being offset.

If sanity checking the data size to prevent an exception from ReadBlock is desired, that should be done within LoadData or the exception caught again within LoadData. Also the file null check there might be redundant since LoadData already does it.

The other change in the same commit seems suspect as well, as empty boxes might be useful and important to keep in various cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant