Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issue with rendering! #264

Open
georgeemr opened this issue Apr 4, 2024 · 5 comments
Open

[BUG] Issue with rendering! #264

georgeemr opened this issue Apr 4, 2024 · 5 comments
Labels

Comments

@georgeemr
Copy link

georgeemr commented Apr 4, 2024

Hi, I'm trying to implement the component but with some animations I get a bad result.
Anyone know what I'm missing?

image

<?xml version="1.0" encoding="utf-8" ?>
<toolkit:Popup xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
               xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
               xmlns:toolkit="http://schemas.microsoft.com/dotnet/2022/maui/toolkit"
               xmlns:skia="clr-namespace:SkiaSharp.Extended.UI.Controls;assembly=SkiaSharp.Extended.UI"
               Color="Transparent"
               x:Class="X.Views.PopUps.LoadingPopup">
    <ContentView>
        <Border BackgroundColor="WhiteSmoke"
                Style="{StaticResource BorderLoty}"
                Padding="15"
                Stroke="Black"
                WidthRequest="250">

            <VerticalStackLayout HorizontalOptions="Center"
                                 VerticalOptions="Center">
               
                <skia:SKLottieView RepeatCount="-1"
                                   RepeatMode="Reverse"
                                   Source="Cat.json"
                                   WidthRequest="250"
                                   HeightRequest="150" />

                <Label HorizontalOptions="Center"
                       Text="Wait"
                       VerticalOptions="Center"
                       HorizontalTextAlignment="Center"></Label>
            </VerticalStackLayout>
        </Border>
    </ContentView>
</toolkit:Popup>

This is the lottie: https://lottiefiles.com/animations/loader-cat-dWUie0iIVk?from=search

Basic Information

I'm using version 2.0.0-preview.92

@georgeemr georgeemr added the bug label Apr 4, 2024
@mattleibow
Copy link
Contributor

Are you able to attach a repro sample? I tested now and it seemed to work fine. Maybe there is some configuration issues or some issue with the version of skia, maybe and the toolkit versions.

@georgeemr georgeemr changed the title Issue with rendering! [BUG] Issue with rendering! Apr 9, 2024
@georgeemr
Copy link
Author

Sure,
I create a project from scratch and the issue. persist.

image

Maui 8.0.7
image

https://1drv.ms/u/s!AlTIxW_ExT1enfFcWZ8yhgAkMaYebA?e=OGdotf

@matthericks
Copy link

I am also running into a similar issue. Loading in a checkmark animation has both a strange checkmark shape and the animation surrounding the circle appears to be wrong.

repo: https://github.com/matthericks/lottie-broken-animation
link to animation in Lottie files: https://app.lottiefiles.com/animation/71e19298-edbb-4d04-a06c-5bd891bea298?panel=download
animation file: success.json

screenshot of checkbox in app: Screenshot 2024-04-19 at 1 05 43 PM

screenshot of expected checkbox:
Screenshot 2024-04-19 at 1 19 53 PM

@mattleibow
Copy link
Contributor

Thanks @matthericks for this lottie. It appears to be a bug in skia directly: https://skottie.skia.org/21af4dec27795f93f0ab6e5f803ea330?h=512&w=512

I see this issue may be the related one: https://issues.skia.org/issues/40043184

There is a comment about Expressions not being supported yet. Do you know if your lottie file uses Expressions?

@matthericks
Copy link

@mattleibow it does not, but that link also had some discussion on the file where I was seeing the issues, and it looks like the checkmark was created using absolute instead of relative coordinates. I updated my file with those coordinates and everything works perfectly.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants