Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitivity for command names #15

Open
md5 opened this issue Sep 25, 2013 · 1 comment
Open

Case insensitivity for command names #15

md5 opened this issue Sep 25, 2013 · 1 comment

Comments

@md5
Copy link

md5 commented Sep 25, 2013

I tried running dex on a Mongo shard log I've got and noticed that it missed a bunch of findAndModify lines. It turns out that the log has "findandmodify" instead of "findAndModify" for the command name. I hacked my copy of parsers.py locally to account for that one special case, but I'm not sure if something more comprehensive should be done. I can open a PR with my changes if it helps, but I'm not sure they're exactly what they should be (in particular, my installed version doesn't have SUPPORTED_COMMANDS in analyzer.py).

@esedor
Copy link
Contributor

esedor commented Oct 4, 2013

A great find. I'll take a look. Preliminary, I don't see a problem with supporting case-insensitive command names, so please do submit your tweak as a pull request, and I will incorporate it differently than as-written if it becomes necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants