Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom reports broke down after upgrading to 1.8.0 #6736

Closed
3 of 11 tasks
feimosi opened this issue May 12, 2024 · 2 comments
Closed
3 of 11 tasks

Custom reports broke down after upgrading to 1.8.0 #6736

feimosi opened this issue May 12, 2024 · 2 comments
Labels
bug
Milestone
v1.8.1

Comments

@feimosi
Copy link

feimosi commented May 12, 2024

MMEX version:

  • 1.7.0
  • 1.8.0
  • 1.8.1
  • 1.8.2
  • Other (please specify)

Note: bug reporters are expected to have verified the bug still exists
either in the last stable version of MMEX or on updated development code
(master branch).

Operating System:

  • Windows
  • Mac OSX
  • Linux

Description of the bug

I've just noticed that after upgrading to v1.8.0, my reports broke down because

  1. the charting library is no longer accessible, I was always importing it like this:

<script src = "ChartNew.js"></script>

Now I can see this error:

image
  1. the default styling disappeared, which I assume is because the styles file changed too:

<link href="master.css" rel="stylesheet">

Can you please guide me what are the current paths to use? The https://github.com/moneymanagerex/general-reports repo has outdated content too.

Reproduction

Is the bug reproducible?

  • Always
  • Randomly
  • Happened only once
@vomikan vomikan added the bug label May 12, 2024
@vomikan vomikan added this to the v1.8.1 milestone May 12, 2024
@lonemadmax
Copy link
Contributor

I was using those paths prefixed by memory: in 1.6.4 and my reports still work after upgrading to current 1.8.1. In fact, I have all the resources prefixed with that. Probably copied them from:

moneymanagerex/src/general_report_manager.cpp

Lines 130 to 147 in 8723054

static const char *HTT_CONTEINER =
R"(<!DOCTYPE html>
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title><TMPL_VAR REPORTNAME></title>
<script src = "memory:ChartNew.js"></script>
<script>
window.Promise || document.write('<script src="memory:polyfill.min.js"><\/script>');
window.Promise || document.write('<script src="memory:classlist.min.js"><\/script>');
window.Promise || document.write('<script src="memory:resize-observer.js"><\/script>');
window.Promise || document.write('<script src="memory:findindex.min.js"><\/script>');
window.Promise || document.write('<script src="memory:umd.min.js"><\/script>');
</script>
<script src = "memory:apexcharts.min.js"></script>
<script src = "memory:sorttable.js"></script>
<link href = "memory:master.css" rel = "stylesheet">
</head>

@feimosi
Copy link
Author

feimosi commented May 14, 2024

Thank you, that did the trick!

@feimosi feimosi closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.8.1
Development

No branches or pull requests
3 participants
@feimosi @vomikan @lonemadmax