Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a light theme? #120

Open
NightMachinery opened this issue Sep 5, 2019 · 7 comments
Open

Is there a light theme? #120

NightMachinery opened this issue Sep 5, 2019 · 7 comments
Labels

Comments

@NightMachinery
Copy link

The current color scheme looks awful on light-themed terminals.

Repository owner deleted a comment from github-actions bot Sep 9, 2019
@moncho
Copy link
Owner

moncho commented Sep 9, 2019

Hi @NightMachinary ,

Sorry there is currently no way to change the color scheme. Could you please share a screenshot of how it looks in a light-themed terminal?

Thanks

@moncho moncho added the question label Sep 9, 2019
@DannyBen
Copy link

DannyBen commented Oct 22, 2019

I second that.... the colors are an issue.
Would love to have a light (as in "don't touch my background" :) theme.

I am attaching a screenshot, in case it is still needed.
image

@moncho
Copy link
Owner

moncho commented Oct 23, 2019

Thanks for the screenshot @DannyBen!! It is not pretty, but is not the worse either ;)

As I said there is no support for changing the color scheme for now, but it might be simpler to add way to use the active background color, I will think about it.

@DannyBen
Copy link

Perhaps the easiest way to approach this is to a) avoid setting ANY background color and b) avoid using the color white for text. From my experience, if these two guidelines are met, most things look good for everybody.

@normen
Copy link

normen commented Dec 5, 2020

I'd agree, I have tried it and simply removed the .Background(b) here

st = st.Foreground(f).Background(b)

And the result fits in MUCH better with my personal color setup.

Before:
Bildschirmfoto 2020-12-05 um 21 22 25

After:
Bildschirmfoto 2020-12-05 um 21 22 53

Would be cool if this was the default @moncho

Thanks for this software, its exactly what I needed :)

@moncho
Copy link
Owner

moncho commented Dec 8, 2020

Thanks for the suggestion, @normen! I have tried it and unfortunately it also removes the background color from the selected items of lists, so it is not enough, sorry.

Great that you like the tool :)

@normen
Copy link

normen commented Dec 8, 2020

Thanks for the suggestion, @normen! I have tried it and unfortunately it also removes the background color from the selected items of lists, so it is not enough, sorry.

Great that you like the tool :)

Hah, sure, it basically removes all background in all styles. I just meant that in general the background should really only be used when needed (i.e. for the CPU use bars etc.) - then it will look fine on most terminals, just as @DannyBen suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants