Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make columns sortable #62

Open
harryhoch opened this issue Apr 9, 2015 · 7 comments
Open

make columns sortable #62

harryhoch opened this issue Apr 9, 2015 · 7 comments

Comments

@harryhoch
Copy link
Collaborator

No description provided.

@harryhoch harryhoch added this to the may 2015 milestone Apr 9, 2015
@davism84
Copy link
Contributor

davism84 commented Sep 2, 2015

@harryhoch I'm assuming this means make the targets sortable, correct?

@harryhoch
Copy link
Collaborator Author

yes. low priority...

On 2 Sep 2015, at 12:26 PM, Michael Davis notifications@github.com wrote:

@harryhoch I'm assuming this means make the targets sortable, correct?


Reply to this email directly or view it on GitHub.


Harry Hochheiser
University of Pittsburgh
Department of Biomedical Informatics
harryh@pitt.edu 412 648 9300

@jmcmurry
Copy link
Member

It would be good to be able to sort by number of matched phenotypes, for example. Fancier ranking would be awesome, but requires some back-end enhancements to Owlsim. see www.github.com/monarch-initiative/owlsim-v3/20

@jmcmurry
Copy link
Member

For clarity, I should mention that the column sorting should spawn another simsearch, not just sort existing results. Otherwise ranking is less useful, esp re: number of matched phenotypes. Having said this, we would still need a lower threshold for what constitutes a hit, otherwise we might get a set of really comprehensive but absurdly fuzzy matches.

@nlwashington
Copy link
Collaborator

longer term, it might be great to visualize the results using hierarchical clustering...once we add individual/patient data, this would be an interesting way of stratifying groups of results by their clustered phenotypes. this may mean the existing approach to be flawed/unscalable but should be considered when making any longer-term decisions. I looked into how to accomplish this using R-shiny, and it was doable quite easily. https://github.com/monarch-initiative/monarch-shiny/tree/master/phenotype_explorer_app. Anyway, I agree that being able to reorganize the results in some way would be really nice.

@jmcmurry
Copy link
Member

In the inverted axis view, I see that at least now the columns are now sortable. Perhaps there are data structure issues that make it non trivial to sort columns in the non-inverted format, but just thought I would prompt clarification on this. @yuanzhou? Fancy stuff is of course a longer-term goal.

@yuanzhou
Copy link
Member

Thanks for the suggestions @jmcmurry @nlwashington, both links that you two mentioned are 404 pages. Right now we can sort the y-axis items by Frequency/Alphabetic/Frequency and Rarity, and the x-axis items are sorted based on their ranking sores. We can definitely think about other fancy ways of sorting them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants