Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prognostic continuous isopycnal does not rearrange entire model state #1086

Open
ashao opened this issue Apr 7, 2020 · 1 comment
Open

Comments

@ashao
Copy link
Collaborator

ashao commented Apr 7, 2020

The 'convective adjustment' performed prior to building the continuous isopycnal coordinate only rearranges layer thicknesses, temperatures, and salinities. If a water column is statically unstable, the regridding thus unphysically breaks the relationships between tracers, velocities, and h, T, and S. To fix this, the convective adjustment thus needs to be made aware of all prognostic quantities associated with a layer.

While this is straightforward to fix for quantities at thickness points, I'm not sure how this would be done for quantities at U/V points. For example, consider two columns: J and J+1 where column J needs to be flipped upside down to be statically stable. How should the meridional-velocities V(J) be rearranged?

In general, this is probably better handled by parameterizing the mixing of both momentum and tracers by convection separately from, but before regridding is done.

@Hallberg-NOAA
Copy link
Collaborator

@ashao , it is not clear to me what parts of the code you are discussing. All of the changes to the water column due to mixing (convective or otherwise) in diabatic_driver are provided to the tracers and are properly accounted for with the velocities as well. There is no re-sorting or flipping of layers in diabatic_driver. If you are referring to some other part of the code, please be more explicit about what routines or files are being discussed with this issue. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants