Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npp diagnostics are incorrect #378

Open
aekiss opened this issue Feb 15, 2023 · 3 comments
Open

npp diagnostics are incorrect #378

aekiss opened this issue Feb 15, 2023 · 3 comments

Comments

@aekiss
Copy link
Collaborator

aekiss commented Feb 15, 2023

As noted in hrsdawson/ACCESS-WOMBAT_01deg_BGC_validation#3 (comment), the diagnostic npp3d is calculated incorrectly (it's phytoplankton growth (f11) minus grazing (f21), but should be phytoplankton growth minus linear mortality (f22)).

! Net primary productivity (gross PP minus linear mortality)
npp3d(i,j,k) = npp3d(i,j,k) + dtsb*(f11 - f21)

We could fix this by replacing f21 (grazing) with f22 (linear mortality).

@aekiss
Copy link
Collaborator Author

aekiss commented Feb 15, 2023

This bug also affects the diagnostics that are derived from npp3 (npp1, npp2d, npp_intmld, npp_int100)

@aekiss
Copy link
Collaborator Author

aekiss commented Mar 23, 2023

@hakaseh should I fix his while we're at it?

@hakaseh
Copy link

hakaseh commented Mar 23, 2023

yes, I thought about that too.
Based on the discussion from COSIMA/access-om2#272, should we consider pprod_gross as NPP ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants