Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode json generation #1072

Open
thestumbler opened this issue Sep 7, 2023 · 2 comments
Open

vscode json generation #1072

thestumbler opened this issue Sep 7, 2023 · 2 comments

Comments

@thestumbler
Copy link

thestumbler commented Sep 7, 2023

I noticed a few quirks with the VSCode JSON files generated in the .vscode directory using the build build -m ::vscode command as described here.

(1) Using these JSON scripts, VSCode reports a deprecated entry:

WAS:   "runToMain": true
IS:    "runToEntryPoint": "main"

(2) The script generating these JSON files is generating them as JSONC (JSON with comments). Looks like VSCode doesn't have any problem reading it, but my editor NEOVIM was a sea of bright red denoting the JSON "errors"

(3) Documentation search oddness... if you search for VSCODE, there are two results. But if you search for "VISUAL STUDIO CODE", only one result (the page about using VSCode along with WSL2 is missing).

VSCode isn't something I'll use very often, but the debugger integration is very good. Much better than I expected.

@salkinium
Copy link
Member

I think that code generation module is a little out-of-date by now, we should upgrade it.

@thestumbler
Copy link
Author

One more small thing I noticed yesterday. The very last line (just a right curly bracket) of the automatically generated files doesn't have a newline. It didn't cause any problems that I'm aware of. But the JSON specification may have something to say about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants