Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit: Default output directory for module-info.class should be META-INF/versions/9 #183

Open
aalmiray opened this issue Mar 6, 2023 · 0 comments

Comments

@aalmiray
Copy link
Contributor

aalmiray commented Mar 6, 2023

Follow up to #67

The fix for this issue has the following comment in code

// #67 It'd be nice to use META-INF/services/9 by default to avoid conflicts with legacy
// classpath scanners, but this causes isses with subsequent jdeps invocations if there
// are MR-JARs and non-MR JARs passed to it due to https://bugs.openjdk.java.net/browse/JDK-8207162

https://bugs.openjdk.org/browse/JDK-8207162 was deemed a duplicate of https://bugs.openjdk.org/browse/JDK-8210502 which was fixed in Java 12. Perhaps ModiTect could detect the running JVM and if it's 12+ apply the desired change, if it's less than 12 then keep the actual behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant