You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
currently for your Maven plugin the overwriteExistingFiles default value is always false, even when the default outputDirectory is used. This is rather inconvenient because due to this you cannot build a project two times without performing mvn clean in between (or as part of the second build); otherwise your plugin fails with:
Execution add-module-info of goal org.moditect:moditect-maven-plugin:1.0.0.RC2:add-module-info failed:
File .../some-project.jar already exists; either set 'overwriteExistingFiles' to true or specify another output directory
If outputDirectory points to the default directory, that is inside target/, then I think it would be reasonable to overwrite the JAR (and maybe other files) by default, similar to how the Maven JAR Plugin overwrites the existing JAR it generated. What do you think? It could be the case though that I forgot to consider a corner case where that is not desired.
Hello,
currently for your Maven plugin the
overwriteExistingFiles
default value is always false, even when the defaultoutputDirectory
is used. This is rather inconvenient because due to this you cannot build a project two times without performingmvn clean
in between (or as part of the second build); otherwise your plugin fails with:To reproduce:
gson-parent-2.9.0
cd gson
mvn package
mvn package
❌ It fails
If
outputDirectory
points to the default directory, that is insidetarget/
, then I think it would be reasonable to overwrite the JAR (and maybe other files) by default, similar to how the Maven JAR Plugin overwrites the existing JAR it generated. What do you think? It could be the case though that I forgot to consider a corner case where that is not desired.It looks like this affects https://github.com/moditect/moditect-gradle-plugin in a similar way.
The text was updated successfully, but these errors were encountered: